Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Turn off event-tracking by default #122

Merged
merged 2 commits into from
Aug 28, 2023
Merged

Turn off event-tracking by default #122

merged 2 commits into from
Aug 28, 2023

Conversation

jfinken
Copy link
Contributor

@jfinken jfinken commented Aug 25, 2023

Disable event-tracking by default.

Tested:

  • osrf/ros:humble-desktop docker image
  • with the change, ran:
$ ./irobot_benchmark/irobot_benchmark \
    --topology src/ros2-performance/irobot_benchmark/topology/white_mountain.json

Result: no events text file present

root@AMER-H62V3J3:~/ros/performance_ws# ll white_mountain_log/
total 28
drwxr-xr-x 2 root      root      4096 Aug 25 14:37 ./
drwxrwxr-x 8 612582126 612582126 4096 Aug 25 14:37 ../
-rw-r--r-- 1 root      root      9403 Aug 25 14:37 latency_all.txt
-rw-r--r-- 1 root      root       192 Aug 25 14:37 latency_total.txt
-rw-r--r-- 1 root      root      1313 Aug 25 14:37 resources.txt

@jfinken
Copy link
Contributor Author

jfinken commented Aug 27, 2023

Thanks @mauropasse and @alsora. At some point, I need one of you to merge this little PR as I don't have write-permissions. Thanks!

@alsora alsora merged commit b65635b into irobot-ros:master Aug 28, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alsora alsora alsora approved these changes

@mauropasse mauropasse mauropasse approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jfinken @mauropasse @alsora